NewWorkspace Wizzard: fix switch workspace after finish #6253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now instead of doing an instant restart (which did not switch to the new workspace) we show the existing Eclipse Switch Workspace dialog but have the new workspace location pre-filled. Since this reuses existing Eclipse feature of OpenWorkspaceAction all the switch workspace logic can be reused. Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
|
I am ok with this. |
|
@pkriens just want to confirm it is working as (I) expected. The "Select workspace" modal dialog appears with the new workspace name prefilled and when I click "Launch" Eclipse restarts and I am in the fresh new workspace.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6252
Now instead of doing an instant restart (which did not switch to the new workspace) we show the existing Eclipse Switch Workspace dialog but have the new workspace location pre-filled. Since this reuses existing Eclipse feature of OpenWorkspaceAction all the switch workspace logic can be reused.
Note, that the screenshot's workspace names do not match since I took them at different times. The first screenshot should have "foo28" as name.
Error on Dev Eclipse instance:
Note: It seems the Switch Workspace feature already does not work in a Development instance of Eclipse (when launched from within Eclipse), because I get the following error:
Thus I would need to merge this once to master, test and see if it works with the next snapshot build in a real Eclipse instance.
@pkriens what do you think? It is a slight change from previous UI workflow (showing switch workspace dialog instead of restarting directly), but since the switch did not work, maybe this is an ok compromise?